-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix terraform output for cluster names that begin with a digit #12202
Conversation
28f84fa
to
e21c767
Compare
Why not simply use a fixed prefix instead of something derived from the resource type? In any case, this can conflict with clusters whose name matches, modulo one of the used prefixes. Perhaps we can use |
I will update this to use the literal |
This will fail until we address each resource type generating terraform resource names that are purely the cluster name
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will fail until we address each resource type generating terraform resource names that are purely the cluster nameThis now includes a proposed fix.
Release notes will need to mention something along the lines of:
I left off the s3 managed files because they're still under feature flag, though terraform may require a second
terraform apply
to get them into a consistent state (race conditions with the same objects being deleted by the old name and created by the new name)fixes: #12199